Add early spatial_extent validation for load_collection/validation with lenient default EPSG:4326 bounds#501
Conversation
Agent-Logs-Url: https://github.com/Open-EO/openeo-python-driver/sessions/f49937f3-cedf-46bb-b843-8bb0ff83e417 Co-authored-by: jdries <5937096+jdries@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Open-EO/openeo-python-driver/sessions/f49937f3-cedf-46bb-b843-8bb0ff83e417 Co-authored-by: jdries <5937096+jdries@users.noreply.github.com>
spatial_extent validation for common user input errors in load_collection//validation
|
@copilot one of the unit tests fails with:
E assert 'Expected dictionary/mapping but got list.' in "The value passed for parameter 'spatial_extent' in process 'load_collection' is invalid: Expected dictionary/mapping but got <class 'list'>." |
Agent-Logs-Url: https://github.com/Open-EO/openeo-python-driver/sessions/7b38d5e1-7c0b-44de-b610-969d8927260a Co-authored-by: jdries <5937096+jdries@users.noreply.github.com>
Fixed in |
|
@copilot on this check: be more lenient on the valid range, to avoid breaking jobs. Allow extra 10 degrees latitude and +-180 degrees longitude |
Agent-Logs-Url: https://github.com/Open-EO/openeo-python-driver/sessions/aeb4752e-91ce-4881-b149-0ac594e40087 Co-authored-by: jdries <5937096+jdries@users.noreply.github.com>
Implemented in |
spatial_extent validation for common user input errors in load_collection//validationspatial_extent validation for load_collection/validation with lenient default EPSG:4326 bounds
|
@copilot add a changelog entry |
Agent-Logs-Url: https://github.com/Open-EO/openeo-python-driver/sessions/65c37f55-6e79-4bde-a5e4-de5d2d7b82a9 Co-authored-by: jdries <5937096+jdries@users.noreply.github.com>
Done in |
| if d["west"] >= d["east"]: | ||
| raise ProcessParameterInvalidException( | ||
| parameter=field, | ||
| process=process_id, | ||
| reason=f"'west' must be smaller than 'east', but got west={d['west']!r} and east={d['east']!r}.", |
There was a problem hiding this comment.
This is going to break anti-meridian use cases
There was a problem hiding this comment.
shall I delete the check, or do you have an example of such a use case?
|
This also broke an integration test where north and south are the same value: @soxofaan Should this be allowed? EDIT: Removed graph from validation list. |
|
Yes, it's easiest to allow it
|
Uh oh!
There was an error while loading. Please reload this page.